Skip to content

add basic search to resource tree - #1915

Closed
aayushkdev wants to merge 1 commit into
aboutcode-org:mainfrom
aayushkdev:file-search
Closed

add basic search to resource tree#1915
aayushkdev wants to merge 1 commit into
aboutcode-org:mainfrom
aayushkdev:file-search

Conversation

@aayushkdev

@aayushkdev aayushkdev commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

#1840

Screencast_20251022_175922.webm

@aayushkdev
aayushkdev requested a review from tdruez October 25, 2025 11:31
@tdruez

tdruez commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

@aayushkdev Off to a great start!

There were a lot of changes implementing #1919 and #1945

I would suggest that you start a new branch from main and rebase those changes there.

Regarding the review:

  • The "X" link should not be there if nothing has started
  • Search box shows overflow above everything
  • I'm not sure about displaying 2 lines per entry, simply display the whole path?
  • Add background on mouse hover
  • Add up/down keyboard navigation
  • Add a "t" keyboard shortcut to set the focus in the search field

Signed-off-by: Aayush Kumar <code@aayushk.dev>
@tdruez

tdruez commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Hey @aayushkdev, do you think you'll find the time to address the feedback on this one to complete this feature set?
Let us know :)

@aayushkdev

Copy link
Copy Markdown
Collaborator Author

Hey sorry for this I've been really busy the past few months, I have my exams in a week after that I will get this feature done for sure

@tdruez

tdruez commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

@aayushkdev no rush, it can wait a few days. Good luck with the exams!

@aayushkdev aayushkdev closed this Mar 23, 2026
@aayushkdev aayushkdev mentioned this pull request Mar 23, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants